feat(mexp): Onboarding Modelexperiments#1547
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
| @@ -0,0 +1,610 @@ | |||
| package token | |||
There was a problem hiding this comment.
A datasource implements the GET request. There is always a datasource present to read a resource. By adding this datasource at least the metadata can be read without using another tool like the CLI or Portal to obtain those informations.
Question for my understanding:
There is an ID and a name returned in the GET request. Can this not be used to reference the token?
API Docs
|
After those comments are resolved I will start to run the acceptance tests and manual testing |
| }, | ||
| "region": schema.StringAttribute{ | ||
| Description: descriptions["region"], | ||
| Optional: true, |
There was a problem hiding this comment.
Needs to be added:
// the region cannot be found, so it has to be passed
Computed: true
| }, | ||
| "region": schema.StringAttribute{ | ||
| Description: descriptions["region"], | ||
| Optional: true, |
There was a problem hiding this comment.
Needs to be added:
// the region cannot be found, so it has to be passed
Computed: true
| deleted_experiment_retention = "30d" | ||
| labels = { | ||
| label = "Example label" | ||
| } |
There was a problem hiding this comment.
This label example does not work (regex validation error)
| description = "Example description" | ||
| deleted_experiment_retention = "30d" | ||
| labels = { | ||
| label = "Example label" |
There was a problem hiding this comment.
This label example does not work (regex validation error)
| description = "Example token description" | ||
| ttl_duration = "1h" | ||
| labels = { | ||
| label = "Example label" |
There was a problem hiding this comment.
This label example does not work (regex validation error)
2 participants
Description
This is the onboarding PR for integration STACKIT Modelexperiments into the STACKIT Terraform Provider.
It adds for customer the ability to:
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)